kiril-keranov opened a new pull request, #418:
URL: https://github.com/apache/commons-logging/pull/418
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
In newer versions of commons-logging the
`org.apache.commons.logging.impl.ServletContextCleaner` is still
`javax.servlet*` compatible. Versions 1.3.x though are widely used in `Tomcat
10/ TomEE 10.1.x` which are `jakarta.servlet.*` compatible, for example latest
versions of TomEE 10.1.x plume include commons-logging 1.3.5 in the tomee/lib
folder.
Thus if someone uses this `ServletContextCleaner` will result in
```
java.lang.NoClassDefFoundError: javax/servlet/ServletContextListener
...
at
org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:345)
at
org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:476)
Caused by: java.lang.ClassNotFoundException:
javax.servlet.ServletContextListener
at
org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1353)
at
org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1165)
... 51 more
```
The PR addresses this issue. Apart from adjusting
`org.apache.commons.logging.impl.ServletContextCleaner` the
`japicmp-maven-plugin` is tuned to exclude this class from the checks in order
not to signal for incompatibility because of the javax->jakarta modification.
The existing `BasicServletTestCase` covers this so new test is not added.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [x] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute?
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [ ] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
