garydgregory commented on PR #381: URL: https://github.com/apache/commons-validator/pull/381#issuecomment-4631253883
@sahvx655-wq -1: There are 2 major problems with this PR. You or your AI are hallucinating requirements and the test is absurdly complicated. The Javadoc for the method you edited reads "Otherwise, property.toString() is returned.". So this PR not only breaks the behavior that has been explicitly documented for 20+ years, it ALSO doesn't update the Javadoc. The test is absurd. You are changing a public API, so you can just have the test call the public API without all this useless XML scaffolding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
