digi-scrypt opened a new pull request, #295: URL: https://github.com/apache/commons-geometry/pull/295
writeObjectName and writeGroupName write the name straight onto the o/g line, so a name with a \r or \n breaks out of that line and the rest is read back as separate OBJ statements (injected vertices/faces, or an mtllib pulling in an arbitrary material file). TextStlWriter.startSolid already guards its solid name against new lines; this adds the same check to the two ObjWriter name methods so the writer can't emit a name that re-parses as geometry. What happens if the name comes from user-supplied metadata is the case I had in mind here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
