alhudz opened a new pull request, #1697:
URL: https://github.com/apache/commons-lang/pull/1697
Repro: `Strings.CI.replace("aİb", "İ", "X", -1)` returns `aİb` instead of
`aXb` under any non-Turkish locale
(`StringUtils.replaceIgnoreCase`/`replaceOnceIgnoreCase` delegate here, so they
are affected too).
Cause: `replace` lower-cases the search argument up front, but the
case-insensitive `indexOf` it calls already matches case-insensitively through
`CharSequenceUtils.regionMatches`. `'İ'` (`U+0130`) lower-cases to the two-char
`"i̇"`, so both the needle and the derived `replLength` grow to length 2 and
stop lining up with the single source character, so the match is silently
dropped.
Fix: remove the redundant lower-casing and let the case-insensitive
`indexOf` do the matching. The case-sensitive path never lower-cased, so it is
unchanged.
The regression test pins the locale with `@DefaultLocale("en")` so the
lower-case expansion is deterministic; it fails on the current code and passes
with the fix.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute?
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
