Trustinbtc999-hue commented on code in PR #393:
URL: https://github.com/apache/commons-email/pull/393#discussion_r3360183578
##########
commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/Email.java:
##########
@@ -830,8 +830,8 @@ public Session getMailSession() throws EmailException {
properties.setProperty(EmailConstants.MAIL_SMTP_SOCKET_FACTORY_FALLBACK,
"false");
}
- if ((isSSLOnConnect() || isStartTLSEnabled()) &&
isSSLCheckServerIdentity()) {
Review Comment:
What's going on with this?
##########
commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/Email.java:
##########
@@ -221,9 +221,9 @@ public abstract class Email {
/**
* If set to true, check the server identity as specified by RFC 2595.
These additional checks based on the content of the server's certificate are
intended
- * to prevent man-in-the-middle attacks. Defaults to false.
Review Comment:
How do I fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
