rootvector2 opened a new pull request, #609:
URL: https://github.com/apache/commons-csv/pull/609
With `QuoteMode.NONE` and both a quote and an escape character set,
`CSVFormat.printWithEscapes` escapes the delimiter, `CR`, `LF` and the escape
character, but never the quote character. A value that begins with the quote
character is written verbatim, so `CSVPrinter` emits a record that its own
`CSVParser` then rejects with `EOF reached before encapsulated token finished`.
Found while round-tripping printed output back through the parser for the
`quote('"').escape('?').QuoteMode.NONE` format already covered by
`testPrintWithQuoteModeIsNONE`.
The quote character is still a token introducer on the parse side regardless
of `QuoteMode`, so the printer has to escape it to stay readable. Adding it to
the escape condition in both `printWithEscapes` overloads (`CharSequence` and
`Reader`) keeps the fix next to where the delimiter and escape char are already
handled, and is guarded so the escape-only path with no quote set is unchanged.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute?
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
