garydgregory commented on code in PR #753:
URL: https://github.com/apache/commons-text/pull/753#discussion_r3407943171
##########
src/main/java/org/apache/commons/text/lookup/StringLookupFactory.java:
##########
@@ -328,7 +328,7 @@ private static Map<String, StringLookup>
parseStringLookups(final String str) {
try {
for (final String lookupName : str.split("[\\s,]+")) {
if (!lookupName.isEmpty()) {
-
addLookup(DefaultStringLookup.valueOf(lookupName.toUpperCase()), lookupMap);
+
addLookup(DefaultStringLookup.valueOf(lookupName.toUpperCase(Locale.ROOT)),
lookupMap);
Review Comment:
Hello @dxbjavid
This change is untested, either remove it or create a test for it.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
