alhudz opened a new pull request, #1703: URL: https://github.com/apache/commons-lang/pull/1703
Repro: `RandomStringUtils.random(10, '0', 'A', true, true, null, rng)` throws `IllegalArgumentException`. Expected: a string of digits, the same as the digits-only call over that range. Actual: it throws, even though `RandomStringUtils.random(10, '0', 'A', false, true, null, rng)` succeeds on the identical range. Cause: the ASCII fast-path guard rejects with `digits && end <= '0' || letters && end <= 'A'`, so a `letters && digits` request trips whenever either category is missing. The range `['0', 'A')` holds the digits but no letters, so the `letters` clause fires. Adding `letters` to a `digits` request can only widen the accepted set, never empty it. Fix: reject only when none of the requested categories is reachable. A range holding neither still rejects through the existing rejection cap. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
