sebbASF commented on PR #1705: URL: https://github.com/apache/commons-lang/pull/1705#issuecomment-4702738881
Whilst it is true that using == to compare strings is generally incorrect, in this case it is essential to ensure that nulls are handled correctly. If both objects return null for toString(), the result should be 0, but it will be 1. Also, the equals comparison at line 74 is redundant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
