rootvector2 opened a new pull request, #610:
URL: https://github.com/apache/commons-csv/pull/610
`printWithQuotes` (the default `MINIMAL` quote mode) decides whether to
encapsulate a value by special-casing only the hard-coded `#`
(`Constants.COMMENT`) as the first character, so a configured comment marker
greater than `#` such as `;` is left unquoted. I hit this round-tripping
printer output back through the parser:
`CSVFormat.DEFAULT.builder().setCommentMarker(';').get()` prints `";id",
"name"` as `;id,name`, and re-parsing with that same format reads the line as a
comment and silently drops the whole record.
The encapsulation check is the right place to fix it, since that is already
where the printer protects the default comment char, the delimiter, the quote
and newlines. The change quotes a value whenever its first character equals the
configured comment marker, so the output reads back as data.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute?
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
