rootvector2 opened a new pull request, #287: URL: https://github.com/apache/commons-jxpath/pull/287
Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [ ] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. `NodePointer.isLanguage` and its `DOMNodePointer`/`JDOMNodePointer` overrides test the language with `String.startsWith`, so `lang()` matches any leading character prefix of the node's `xml:lang` (or the locale name) instead of a whole subtag. I noticed it reading the `lang()` predicate path: a node with `xml:lang="fr"` satisfies `lang('f')`, and a locale of `en-US` satisfies `lang('e')` and `lang('en-')`, all of which must be false per XPath 1.0 section 4.3, which matches only when the argument equals the tag or a subtag delimited by `-`. Since `lang()` is used in predicates to select nodes, the over-match changes which nodes a filter returns for caller-supplied `xml:lang` data. The fix requires an exact case-insensitive match or a `lang-` prefix, in one shared helper used by all three implementations. The added assertions fail on the current code (`lang('f')` and `lang('e')` return true) and pass with the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
