garydgregory commented on PR #504: URL: https://github.com/apache/commons-bcel/pull/504#issuecomment-4729551643
Hello @rootvector2 Thank you for your PR. LGTM. 1. The JVM spec [here](https://docs.oracle.com/javase/specs/jvms/se25/html/jvms-4.html#jvms-4.10.1.9.multianewarray:~:text=The%20dimensions%20operand%20of%20each%20multianewarray%20instruction%20must%20not%20be%20zero.) states "The dimensions operand of each multianewarray instruction must not be zero." Would you please check the byte code verifier for this constraint? 2. Do you see similar signed vs. unsigned issues in other implementations of `org.apache.bcel.generic.Instruction.initFromFile(ByteSequence, boolean)`? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
