garydgregory commented on code in PR #1711:
URL: https://github.com/apache/commons-lang/pull/1711#discussion_r3428049645
##########
src/main/java/org/apache/commons/lang3/BitField.java:
##########
@@ -82,7 +82,7 @@ public class BitField {
* @param mask the mask specifying which bits apply to this BitField. Bits
that are set in this mask are the bits that this BitField operates on.
*/
public BitField(final int mask) {
- this.mask = mask;
+ this.mask = Integer.toUnsignedLong(mask);
this.shiftCount = mask == 0 ? 0 : Integer.numberOfTrailingZeros(mask);
Review Comment:
Hello @alhudz
Thank you for the PR.
Should the argument to `numberOfTrailingZeros` be `mask` or `this.mask`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
