alhudz opened a new pull request, #1715: URL: https://github.com/apache/commons-lang/pull/1715
`ObjectUtils.median` collapses equal values before picking the middle element, so the result comes from the set of distinct values rather than from all the values passed in. Repro: `ObjectUtils.median(5, 5, 5, 1)` returns `1`; `ObjectUtils.median(1, 2, 3, 3, 3, 4)` returns `2`. Expected: `5` and `3` respectively, the middle of the total values (lower of the two middles for an even count) as the Javadoc states. Cause: both overloads load the varargs into a `TreeSet`, which discards duplicates, then index it by `(size - 1) / 2`. Fix: sort a clone of the input array with `Arrays.sort` so equal elements are kept; the index and the existing distinct-value results are unchanged. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
