rootvector2 opened a new pull request, #403: URL: https://github.com/apache/commons-beanutils/pull/403
Port of #401 to the `1.X` branch. `DecimalLocaleConverter.parse` builds a `DecimalFormat` but never enables `setParseBigDecimal`, so `DecimalFormat.parse` returns a clamped `Long` (when the value fits in long) or a lossy `Double` (out of long range). `BigIntegerLocaleConverter` and `BigDecimalLocaleConverter` then derive their result from that `Number`, so a value past `long`/`double` range comes back silently wrong: `9999999999999999999` becomes `9223372036854775807` for `BigInteger` and `1.0E+19` for `BigDecimal`. The non-locale `BigIntegerConverter`/`BigDecimalConverter` avoid this by parsing the string directly. Added a protected `isParseBigDecimal()` hook (default `false`) on `DecimalLocaleConverter` and pass it to `formatter.setParseBigDecimal(...)`; only `BigIntegerLocaleConverter` and `BigDecimalLocaleConverter` override it to `true`, so `DecimalFormat` returns a lossless `BigDecimal` for them while the narrowing `Byte`/`Short`/`Integer`/`Long`/`Float`/`Double` converters keep the `Long`/`Double` path. `BigIntegerLocaleConverter` converts the `BigDecimal` via `toBigInteger()`. Added regression tests to `BigIntegerLocaleConverterTest` and `BigDecimalLocaleConverterTest`; both fail without the runtime change (`9223372036854775807` and `1.0E+19` respectively). `mvn test -Dtest='*LocaleConverterTest'` is green (106 tests). The only failure in a full `mvn` run is `LocaleBeanificationTest.testContextClassloaderIndependence`, a pre-existing flake unrelated to this change (it fails the same way on a clean `1.X` checkout). - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [ ] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
