alhudz opened a new pull request, #1729:
URL: https://github.com/apache/commons-lang/pull/1729
1. `getDigits` scans the input one `char` at a time and calls
`Character.isDigit(char)`, so a supplementary digit such as `U+1D7CF`
(MATHEMATICAL BOLD DIGIT ONE) is dropped: neither surrogate half is itself a
digit, even though `Character.isDigit` reports the code point as a digit.
2. Switched the scan to code points (`codePointAt`/`charCount`) and write
the matched code point back with `Character.toChars`.
Repro `getDigits("a" + new String(Character.toChars(0x1D7CF)) + "9")`:
expected the supplementary digit then `9`, actual `9`. BMP input (including the
existing Devanagari case) is unchanged.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute?
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
