rootvector2 commented on PR #618: URL: https://github.com/apache/commons-csv/pull/618#issuecomment-4806549427
Took a look. The double-consume was specific to `nextToken`'s leading-whitespace skip, since that's the only place that called `isDelimiter` twice on the same char. `parseSimpleToken` and `parseEncapsulatedToken` each call it once per char, so they were never affected. I also ran a whitespace-prefixed multi-char delimiter through the other whitespace-sensitive configs: `trim`, a tab-prefixed delimiter (`\t|`), a quoted token followed by such a delimiter, and a trailing-whitespace delimiter (`| `). All of them parse correctly now. Nothing else stood out, but I'll keep poking and open a separate PR if something falls out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
