alhudz opened a new pull request, #755:
URL: https://github.com/apache/commons-text/pull/755
Port of apache/commons-lang#1731 to the Commons Text copy of `WordUtils`, as
requested by @garydgregory.
`WordUtils.wrap(str, wrapLength, newLineStr, true)` hard-breaks a too-long
word at the fixed char offset `wrapLength + offset` and inserts the new line
there. When that offset lands between the high and low surrogate of a
supplementary code point the pair is split, so a lossless wrap emits a lone
high surrogate at the end of one line and a lone low surrogate at the start of
the next.
Repro: `WordUtils.wrap("a😀😀😀😀", 4, "\n", true)` (`a` then four `U+1F600`).
Before: `a😀\uD83D` `\n` `\uDE00😀\uD83D` `\n` `\uDE00`, i.e. the 2nd and 4th
emoji are split around the `\n`.
After: `a😀😀\n😀😀`, no lone surrogates.
Fix: nudge the break one char forward when it would land inside a pair, so
the whole code point stays on the current line. BMP input and the
delimiter-based wrap paths are unaffected, and the other `wrap` overloads
delegate to this method.
Added assertions to `WordUtilsTest#testWrap_StringIntStringBoolean` that
fail on the current tree and pass with the fix.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute?
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
