garydgregory commented on code in PR #406:
URL: https://github.com/apache/commons-jexl/pull/406#discussion_r3482173048
##########
src/changes/changes.xml:
##########
@@ -27,10 +27,13 @@
<author email="[email protected]">Commons Developers</author>
</properties>
<body>
- <release version="3.6.4" date="2026-06-24" description="This is a
feature and maintenance release. Java 8 or later is required.">
Review Comment:
Keep version 3.6.4.
##########
src/main/java/org/apache/commons/jexl3/scripting/JexlScriptEngineFactory.java:
##########
@@ -145,7 +145,7 @@ public String getLanguageName() {
@Override
public String getLanguageVersion() {
- return "3.6"; // this should be derived from the actual version
+ return "3.7"; // this should be derived from the actual version
Review Comment:
This magic string is in more than one place. Refactoring to a constant?
##########
src/site/xdoc/index.xml:
##########
@@ -22,6 +22,53 @@
</properties>
<body>
+ <section name="Breaking change in 3.7.0">
Review Comment:
I think the section title should make it clear that this is a _behavior_
change, not a _binary compatibility_ break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
