rootvector2 commented on PR #426: URL: https://github.com/apache/commons-cli/pull/426#issuecomment-4826454680
Rebased on master. You're right that pinning `Locale.ENGLISH` outright would break `testDateLocaleDe` and any app passing a default-locale string, so I went with the parse-twice route: `Converter.DATE` now parses with the default locale first and only falls back to `Locale.ENGLISH` when that throws. Anything that parses today hits the exact same first parse, so existing behavior is unchanged; the fallback only covers the `Date.toString()` output, which is always English regardless of locale. Added `testDateLocaleDeEnglishInput` to lock that path under a `de` default. Both it and your `testDateLocaleDe` pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
