rootvector2 opened a new pull request, #620: URL: https://github.com/apache/commons-csv/pull/620
`printWithQuotes` in MINIMAL quote mode does not encapsulate a value whose tail is a straddling prefix of a multi-character delimiter, so the printed record cannot be read back. With delimiter `||`, a field ending in `|` such as `a|` is written unquoted, and the record `a|||b` is then parsed by `CSVParser` as `[a, |b]` because the greedy lexer matches the delimiter one character early at the value/delimiter boundary. The existing scan only quotes when the full delimiter occurs inside the value; a trailing partial delimiter slips through. Fixed by `endsWithDelimiterPrefix`, which quotes the value when appending the delimiter after it would create a boundary-straddling delimiter match. Single-character delimiters and values that contain the delimiter start without a straddling suffix (for example delimiter `[|]`, value `a[`) are unaffected. Found while auditing multi-character delimiter round-trips through the printer. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
