sahvx655-wq commented on PR #416: URL: https://github.com/apache/commons-validator/pull/416#issuecomment-4882023462
Makes sense. I'd only added the regression to the four integer validators that route straight through the changed non-fraction branch (Byte/Short/Integer/Long), but you're right that every concrete subclass should exercise the inherited overloads. I've now added the same testNumberRangeExactBound to FloatValidatorTest, CurrencyValidatorTest and PercentValidatorTest. Float hits the unchanged fraction branch and Currency/Percent inherit BigDecimalValidator's exact-compare override, so those assert the behaviour stays correct through each concrete class rather than failing on the old tree. Double, BigDecimal and BigInteger already carry equivalent coverage from the earlier range fixes (testDoubleNumberRangeExactBound, testNumberRangeBeyondDoublePrecision, and testNumberRangeOutsideLongRange/testNumberRangeFractionalBound/testNumberRangeNonFiniteBound), so the whole hierarchy is now covered. Full mvn build is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
