rootvector2 opened a new pull request, #517: URL: https://github.com/apache/commons-bcel/pull/517
`LocalVariableTable.getLocalVariable(index, pc)` treats `pc == startPc + getLength()` as in scope, but JVMS 4.7.13 defines a local variable's live range as the half-open interval `[start_pc, start_pc + length)`, so a query at `start_pc + length` returns a variable that is already out of scope and reports the wrong variable as live at that program counter for a parsed class. The generation side already treats the end as exclusive (`MethodGen` derives length from `end - start`). Found while auditing the range checks in the local-variable attributes. The added test builds a variable live over `[2, 5)` and asserts `getLocalVariable(1, 5)` is `null`, which fails before the change. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
