paulk-asert commented on code in PR #703: URL: https://github.com/apache/commons-collections/pull/703#discussion_r3532139242
########## src/test/java/org/apache/commons/collections4/multiset/UnmodifiableSortedMultiSetTest.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.collections4.multiset; + +import static org.junit.jupiter.api.Assertions.assertSame; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + +import java.util.Arrays; + +import org.apache.commons.collections4.SortedMultiSet; +import org.apache.commons.collections4.Unmodifiable; +import org.junit.jupiter.api.Test; + +/** + * Extension of {@link AbstractSortedMultiSetTest} for exercising the + * {@link UnmodifiableSortedMultiSet} implementation. + */ +public class UnmodifiableSortedMultiSetTest<E> extends AbstractSortedMultiSetTest<E> { + + @Override + public String getCompatibilityVersion() { + return "4.6"; + } + + @Override + public boolean isAddSupported() { + return false; + } + + @Override + public boolean isRemoveSupported() { + return false; + } + + @Override + public SortedMultiSet<E> makeFullCollection() { + final SortedMultiSet<E> multiset = new TreeMultiSet<>(); + multiset.addAll(Arrays.asList(getFullElements())); + return UnmodifiableSortedMultiSet.unmodifiableSortedMultiSet(multiset); + } + + @Override + public SortedMultiSet<E> makeObject() { + return UnmodifiableSortedMultiSet.unmodifiableSortedMultiSet(new TreeMultiSet<>()); + } + + @Test + void testAdd() { + final SortedMultiSet<E> multiset = makeFullCollection(); + final SortedMultiSet<E> unmodifiableMultiSet = UnmodifiableSortedMultiSet.unmodifiableSortedMultiSet(multiset); + assertThrows(UnsupportedOperationException.class, () -> unmodifiableMultiSet.add((E) "One", 1)); + } + + @Test + void testDecorateFactory() { + final SortedMultiSet<E> multiset = makeFullCollection(); + assertSame(multiset, UnmodifiableSortedMultiSet.unmodifiableSortedMultiSet(multiset)); + + assertThrows(NullPointerException.class, () -> UnmodifiableSortedMultiSet.unmodifiableSortedMultiSet(null)); + } + + @Test + void testEntrySet() { + final SortedMultiSet<E> multiset = makeFullCollection(); + final SortedMultiSet<E> unmodifiableMultiSet = UnmodifiableSortedMultiSet.unmodifiableSortedMultiSet(multiset); + assertSame(unmodifiableMultiSet.entrySet().size(), multiset.entrySet().size()); + } Review Comment: fixed and did the same for the existing UnmodifiableMultiSetTest too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
