rootvector2 opened a new pull request, #710: URL: https://github.com/apache/commons-collections/pull/710
Follow-up to #705, per the review request to check the rest of the library for int/long mismatches. `CompositeCollection.size()`, `CompositeSet.size()` and `CompositeMap.size()` sum the composited containers' sizes into an `int`, so two max-size members wrap the total negative (`CompositeMap`'s javadoc already promises `Integer.MAX_VALUE`); compositing two full bags makes this cheap to hit. `AbstractMultiValuedMap.size()` and `AbstractMultiSet.size()` accumulate value collection sizes and entry counts the same way. All five now sum into a `long` and clamp the return to `Integer.MAX_VALUE`, matching the `Collection.size()` contract and the #705 idiom. The regression tests fail before the change (`-2` from two max-size members) and pass after: the `CompositeCollection` and `AbstractMultiValuedMap` tests use real `HashBag`s at max count, the set/map tests use empty-iterating members that report `Integer.MAX_VALUE`. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
