garydgregory commented on code in PR #706:
URL:
https://github.com/apache/commons-collections/pull/706#discussion_r3562644522
##########
src/main/java/org/apache/commons/collections4/multimap/UnmodifiableMultiValuedMap.java:
##########
@@ -114,6 +114,13 @@ public Set<K> keySet() {
return UnmodifiableSet.unmodifiableSet(decorated().keySet());
}
+ /**
+ * {@inheritDoc}
+ * <p>
+ * The returned map iterator's {@link MapIterator#setValue(Object)} method
is not supported
Review Comment:
This is only partially true, why mention one mutator method and not another?
Wouldn't it be simpler to say that the returned object is unmodifiable? The
same type of issue must be verified for each of the changes in this PR and this
is not something I want to spend time doing ATM. I think we should close this
PR and move on to actual bug fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
