alhudz opened a new pull request, #762:
URL: https://github.com/apache/commons-text/pull/762
Ports apache/commons-lang#1745 to `TextStringBuilder`, as requested there.
`Repro`: `new TextStringBuilder("K").equalsIgnoreCase(new
TextStringBuilder("K"))` (KELVIN SIGN `U+212A` vs `K`) returns `false`, and so
does the å/ANGSTROM pair `new TextStringBuilder("å").equalsIgnoreCase(new
TextStringBuilder("Å"))`. `String.equalsIgnoreCase` returns `true` for both.
`Cause`: the per-character loop only rules a differing pair equal when
`Character.toUpperCase(c1) == Character.toUpperCase(c2)`. Characters that fold
together only through their lower-case mapping (`U+212A` -> `k`, `U+212B` ->
`å`) fail that test, so the whole compare reports not-equal.
`Fix`: also accept the pair when `Character.toLowerCase` of the upper-cased
chars agrees, the same fold `String#regionMatches` uses. Regression assertions
added to `TextStringBuilderTest#testEqualsIgnoreCase` fail at the Kelvin pair
without the main change and pass with it; all 124 tests in the class pass, and
the default `mvn` build is green.
---
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute?
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
