kvr000 commented on PR #378: URL: https://github.com/apache/commons-compress/pull/378#issuecomment-4951058482
I'd be cautious about that - maybe not too common with zip archives but some software may simply append to file when the entry is modified, instead of rearranging the existing stream (central directory must be still rewritten or newly appended though). So formally this is valid situation and the last entry should be returned as the valid one (in case one entry is requested) - correcting my earlier proposal to return the first one - that would be wrong. Anyway, if the benchmark is slower for multiple entries but it's the same or rather faster for single entry - that is good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
