tomasilluminati commented on PR #776: URL: https://github.com/apache/commons-compress/pull/776#issuecomment-4959925712
@Marcono1234 Sorry about the resolve on the Files#readAttributes thread, that was me tidying the view by accident, not dismissing your point. I've reopened it. You're right that readAttributes only documents IOException and NoSuchFileException is an optional specific exception, so relying on it is fragile. Changed it to catch IOException and confirm with Files.notExists(current, NOFOLLOW_LINKS) before creating, kept e instanceof NoSuchFileException as the fast path, and rethrow anything else, so a real error like denied access (where notExists returns false) is no longer masked as "missing". Thanks for catching this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
