sahvx655-wq opened a new pull request, #424:
URL: https://github.com/apache/commons-validator/pull/424
DomainValidator.isValid accepts a non-ASCII domain label that begins or ends
with a hyphen: isValid("-tést.fr") and isValid("tést-.fr") both return true,
though the all-ASCII forms "-test.fr" and "test-.fr" are correctly rejected.
This is VALIDATOR-501, whose DomainValidatorTest.testInvalidDomains501 has been
sitting @Disabled. The divergence is in the shared unicodeToASCII helper: for a
label carrying a non-ASCII character it defers to IDN.toASCII, which with the
default flags does not apply the LDH rule and punycode-encodes the boundary
hyphen ("-tést" becomes "xn---tst-cpa"), so the converted label starts and ends
alphanumeric, DOMAIN_LABEL_REGEX matches, and the hyphen the ASCII path would
have caught slips through. UrlValidator.isValidAuthority and the EmailValidator
domain check share unicodeToASCII, so they inherit the same hole.
The fix scans the original input before conversion and, when any label opens
or closes with a hyphen, returns it unchanged so the label regex rejects it,
matching the format-code-point guard added a few lines above. It splits on the
four label separators from RFC 3490 section 3.1 and leaves an interior hyphen
alone, so "a-é.fr" keeps validating while "-é.fr" does not. Keeping the check
in the shared helper closes the gap for DomainValidator, UrlValidator and
EmailValidator in one place rather than in each caller. I enabled
testInvalidDomains501 and added the "-é.fr"/"a-é.fr" pair; the full suite stays
green.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute?
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
