rootvector2 opened a new pull request, #775: URL: https://github.com/apache/commons-vfs/pull/775
`DefaultFileReplicator` pins its replica directory to `<java.io.tmpdir>/vfs_cache`, a fixed name under a directory every local user can write to, and leaves creation to `mkdirs` under the default umask. Everything the library replicates lands there world-readable, including the whole remote archive that `ZipFileSystem` and `TarFileSystem` copy through `replicateFile` before opening it. Because the name is known up front, another local user can also pre-create `vfs_cache` as a symlink and collect the replicas, or swap a replicated jar before `VFSClassLoader` reads it; found while auditing where the library writes files on the caller's behalf. Allocate the directory with `Files.createTempDirectory` on first use instead. It picks an unguessable name and creates it `rwx------` on POSIX file systems in a single step, so there is no window between creation and a chmod. Keeping this in the replicator puts the guarantee where the directory's lifetime is already managed, and an application that wants a specific location still passes one to the `DefaultFileReplicator(File)` constructor. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
