ppkarwasz commented on code in PR #44:
URL: https://github.com/apache/commons-xml/pull/44#discussion_r3856400143
##########
src/test/java/org/apache/commons/xml/ShadingFootprintTest.java:
##########
@@ -69,23 +70,25 @@ class ShadingFootprintTest {
private static final Set<String> STAX_HARDENER = set("StaxHardener",
"HardeningXMLInputFactory", "FallbackIgnoreXMLResolver", HARDENING_EXCEPTION);
/**
- * TrAX, XPath and schema re-harden their sub-parsers through {@link
SAXParserHardener#harden(Source)}, so each builds on the full SAX closure below.
+ * TrAX, XPath and schema re-harden their sub-parsers through {@link
SAXParserHardener#hardenSource(Source)}, so each builds on the full SAX closure
below; XPath
+ * additionally parses InputSource-taking evaluate calls through the DOM
hardener, so its closure carries that set too.
*/
private static final Set<String> TRANSFORMER_HARDENER =
saxParsersHardenerPlus("TransformerHardener", "HardeningTransformerFactory",
"HardeningTransformer", "HardeningTransformerHandler",
"HardeningTemplates", "HardeningTemplatesHandler", "HardeningXMLFilter",
"FallbackIgnoreURIResolver", "SaxonProvider", "SaxonProvider$1",
"SaxonProvider$HardenedConfiguration"
, "SaxonProvider$SaxonProviderConfigurer");
- private static final Set<String> XPATH_HARDENER =
saxParsersHardenerPlus("XPathHardener", "FallbackIgnoreURIResolver",
"SaxonProvider", "SaxonProvider$1",
- "SaxonProvider$HardenedConfiguration",
"SaxonProvider$SaxonProviderConfigurer");
+ private static final Set<String> XPATH_HARDENER =
saxParsersHardenerPlus("XPathHardener", "FallbackIgnoreURIResolver",
"SaxonProvider",
+ "SaxonProvider$1", "SaxonProvider$HardenedConfiguration",
"SaxonProvider$SaxonProviderConfigurer", "HardeningXPathFactory",
"HardeningXPath",
+ "HardeningXPathExpression", "DocumentBuilderHardener",
"HardeningDocumentBuilder", "HardeningDocumentBuilderFactory");
private static final Set<String> SCHEMA_HARDENER =
saxParsersHardenerPlus("SchemaHardener", "HardeningSchemaFactory",
"HardeningValidator",
"HardeningValidatorHandler", "HardeningSchema",
"FallbackIgnoreLSResourceResolver");
/**
* Only the public {@link XmlFactories} entry, which news up every
hardener, still pulls the whole library; this is its class count.
Review Comment:
Apparently it is short for “instantiates”. Fixed in
https://github.com/apache/commons-xml/pull/44/commits/eb53959e3703f57263f3c349b3d1d74e94928d20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
