ppkarwasz commented on code in PR #43: URL: https://github.com/apache/commons-xml/pull/43#discussion_r3857119583
########## src/site/markdown/threat_model.md: ########## @@ -230,12 +235,23 @@ and reports against a factory reconfigured in any of the ways below are out of s To parse with your own reader under the hardening guarantees, obtain it from `XmlFactories.newSAXParserFactory()` before wrapping it in a `SAXSource`. -- The behavior of a JAXP implementation that `XmlFactories` does not recognize (it throws rather than returning an - unhardened factory), and any defect in the underlying JAXP implementation itself. +- The behavior of a JAXP implementation that does not respect the contract of the settings a hardening recipe requires + (the factory method throws rather than returning an unhardened factory), + and any defect in the underlying JAXP implementation itself. - **Android, on any API level.** No version of Android supports `FEATURE_SECURE_PROCESSING`, so the hardening there is best-effort and no guarantee is defined (see **Supported runtimes** under [Assumptions about the environment](#assumptions-about-the-environment)). +- **Transform output destinations.** + The hardening governs what a parse or transform reads; + it does not confine what a transform writes. Review Comment: It wasn't mentioned anywhere else. Now it is, one sentence each: threat model's "Scope and intended use", the site index page, and the `newTransformerFactory` Javadoc (0d499c7). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
