tanvir-ux opened a new pull request, #440: URL: https://github.com/apache/commons-cli/pull/440
Fixes https://issues.apache.org/jira/browse/CLI-300 ## Summary `DefaultParser.handleShortAndLongOption` only treated the left-hand side of an equals token as a short option when it was a single character (`opt.length() == 1`). A multi-character short option such as `Option.builder("foo").hasArg()` therefore failed on `-foo=bar` with `UnrecognizedOptionException`, while `-f=bar` and `-foo bar` already worked. ## Change Use `Options.hasShortOption(opt)` for the equals path, matching the non-equals short-option lookup already used a few lines above. Single-character short options, Java-property style (`-Dkey=value`), and long options with a single dash (`-foo=bar` with `longOpt("foo")`) keep the same behavior. ## Tests - `DefaultParserTest#testMultiCharShortOptionWithEqual` — regression for the reported case - `DefaultParserTest#testMultiCharShortOptionWithoutEqual` — paired non-equals path - Full `mvn` build succeeds locally - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Assisted with drafting the patch and PR text; change and tests authored and verified locally as Md Tanvir Alam. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
