skrcode opened a new pull request, #218: URL: https://github.com/apache/commons-numbers/pull/218
Completes the Commons RNG 1.7 upgrade in #217 without changing the dependency bump. `partitionLSP` recursively selects a pivot from the median sample. The returned selection bounds can be wider than the contiguous equal-pivot run, but the move-sample path treated the complete range as equal. With the deterministic samples produced by RNG 1.7, that caused both a wrong selected value and destructive replacement of an array element. This keeps the selected index as the pivot authority and derives only the contiguous equal run around it before moving the sample. The optional sample-move optimization remains enabled; no public API or build configuration changes. Verification (Java 21.0.9, Maven 3.9.16): - Exact parent `9025ab0559e2de9990a3aa92158e8e1292cf22e0`: focused `PartitionTest#testPartitionLSPMoveSample` passed (411 invocations, 0 failures). - Exact Dependabot head `98225502fbbc13091ccd7405285363894e79072a`: the identical command failed 2 cases, reproducing CI (wrong order statistic and destroyed array contents). - Candidate: the identical focused command passed (411 invocations, 0 failures). - Full affected reactor: 44,818 JMH tests passed, including 29,142 `PartitionTest` invocations. - CI-parity clean gate: `mvn --show-version --batch-mode --no-transfer-progress -Pexamples clean install -Dmaven.javadoc.skip` passed all 16 modules. - Separate CI Javadoc gate: `mvn --show-version --batch-mode --no-transfer-progress -Pexamples javadoc:javadoc -Dmaven.javadoc.skip=false` passed all 16 modules. - `git diff --check` passed. Signed-off-by is included in the commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
