ppkarwasz commented on code in PR #59:
URL: https://github.com/apache/commons-xml/pull/59#discussion_r3880781098
##########
src/main/java/org/apache/commons/xml/HardeningXPathFactory.java:
##########
@@ -246,14 +226,29 @@ public boolean isObjectModelSupported(final String
objectModel) {
@Override
public XPath newXPath() {
final XPath xpath = delegate.newXPath();
- return xpath == null ? null : new HardeningXPath(xpath);
+ return xpath == null ? null : new HardeningXPath(xpath,
useDefaultParser());
}
@Override
public void setFeature(final String name, final boolean value) throws
XPathFactoryConfigurationException {
delegate.setFeature(name, value);
}
+ /**
+ * Whether {@code jdk.xml.overrideDefaultParser} on the delegate
currently asks for the platform's built-in parser; the engine's internal parser
is
Review Comment:
Fixed in
https://github.com/apache/commons-xml/pull/59/commits/5a2d7039a73eca45bc095d99edea023f07af75c6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
