ppkarwasz commented on code in PR #95:
URL: https://github.com/apache/commons-secure-xml/pull/95#discussion_r4001114065
##########
src/main/javadoc/overview.html:
##########
@@ -315,8 +315,20 @@ <h2>Caching and Thread-Safety</h2>
<p>
There is no caching or pooling inside
<code>org.apache.commons.xml.secure</code>;
- callers on a hot path are responsible for their own caching. The
returned factories inherit the thread-safety properties of the underlying JAXP
- implementation, which in practice means they are not thread-safe.
Create a new factory per thread or synchronize externally.
+ callers on a hot path are responsible for their own caching.
Review Comment:
What we do here is not caching, it is implementation details.
I removed them in
https://github.com/apache/commons-secure-xml/pull/95/commits/a06c6dd338cd245ca8595bc1ac34cf2390a2ab43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
