Copilot commented on code in PR #416:
URL: https://github.com/apache/commons-jexl/pull/416#discussion_r4006150454
##########
pom.xml:
##########
@@ -338,7 +338,7 @@
<configuration>
<configLocation>${basedir}/src/main/config/checkstyle.xml</configLocation>
<suppressionsLocation>${basedir}/src/main/config/checkstyle-suppressions.xml</suppressionsLocation>
- <excludes>org/apache/commons/jexl3/parser/*.java</excludes>
+
<excludes>org/apache/commons/jexl3/parser/*.java,org/apache/commons/jexl3/CursorTest.java,org/apache/commons/jexl3/SmoothSort.java</excludes>
Review Comment:
The build and reporting Checkstyle configurations are explicitly required to
agree (see the comment at pom.xml:224), but this change adds `CursorTest.java`
and `SmoothSort.java` only to the reporting `<excludes>`; the
`checkstyle:check` configuration at pom.xml:231 still checks them. Apply the
same exclusions to the build configuration as well, or remove this report-only
addition so the two configurations remain consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
