aakarsh-34 opened a new pull request, #1790:
URL: https://github.com/apache/commons-lang/pull/1790
…LUE numerator
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Fixes LANG-1834.
Fraction.getReducedFraction(Integer.MIN_VALUE, -2) previously threw an
ArithmeticException, even though the fraction can be safely reduced to
1073741824/1 before sign normalization.
This adds a special case for when the numerator is Integer.MIN_VALUE and
the denominator is even, mirroring the existing special case already
handled for the denominator.
Added a test verifying the fix.
Thanks for your contribution to [Apache
Commons](https://commons.apache.org/)! Your help is appreciated!
Before you push a pull request, review this list:
- [x ] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ x] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [x ] I used AI to create part of this pull request. I used Claude to help
me understand the existing code, work through the logic for the fix, and write
the test case.
- [ x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x ] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
