ppkarwasz opened a new pull request, #110: URL: https://github.com/apache/commons-jelly/pull/110
`<xu:assertDocumentsEqual>` fed the XML text of both dom4j documents to XMLUnit's `Diff`, which re-parses it with XMLUnit's own JAXP `DocumentBuilder`. That parser fetches the external DTD of any document with a DOCTYPE, regardless of how the documents were read in the first place. The tag now builds the two DOM trees itself with a `DocumentBuilder` from Commons Secure XML and hands those to `Diff(Document, Document)`, so no external entity is fetched on the comparison path either. The `ignoreWhitespace` attribute still reaches the builder, as it did through XMLUnit's global setting, and XMLUnit's whitespace stripping keeps working on the trees it receives. A regression test compares an in-memory document whose DOCTYPE points to a DTD that does not exist, with and without `ignoreWhitespace`, since the latter routes the trees through XMLUnit's whitespace-stripping transform. Both cases fail on master and pass with this change. Independent of the dom4j 2.1.5 / `SAXReader` pull request; together they close both external-fetch paths of the xmlunit tag library. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
