alhudz opened a new pull request, #1815:
URL: https://github.com/apache/commons-lang/pull/1815
1. Since Java 9, `SimpleDateFormat` compiles a month-only pattern with
`forceStandaloneForm` (JDK-8114833) and formats the text month of `MMM`/`MMMM`
with the standalone month names.
2. `FastDatePrinter` always takes the `M` text month from
`DateFormatSymbols`, the format form, so the two disagree wherever the
grammatical forms differ.
3. `parsePattern` now uses the standalone tables already used by the `L`
rules when the month is the pattern's only field, mirroring the
`SimpleDateFormat` rule, on Java 9 and later; patterns with any other field,
`L` patterns and Java 8 are unchanged.
Repro: `FastDateFormat.getInstance("MMMM", TimeZones.GMT, new
Locale("ru")).format(date)` for 2024-02-10.
Expected (what `SimpleDateFormat` returns): `февраль` (nominative).
Actual: `февраля` (genitive, "of February"). `ru`, `uk`, `be`, `pl`, `cs`,
`sk`, `hr`, `lt`, `fi`, `ca` and `el` differ for `MMMM`; `de` and `fi` also
differ for `MMM` abbreviations.
Verified with a differential against `SimpleDateFormat` over 13320
pattern/locale/month cases including quoted literals and multi-field controls:
mismatches before, 0 after, plus 1776 round trips through `parse`, which
already accepts both forms because `FastDateParser` reads names with
`Calendar.ALL_STYLES`. The new test fails before the runtime change (`de_DE MMM
expected: <Jan> but was: <Jan.>`) and passes after.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [x] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [x] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute? Claude Code was used to find the divergence and draft the fix and
test; the result was reviewed, and the build and tests were run locally.
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
