sharanggupta opened a new pull request, #797: URL: https://github.com/apache/commons-vfs/pull/797
The JUnit 5 migration in #730 deleted `CacheTestSuite` and the five `*FilesCacheTestCase` classes that ran the `FilesCache` tests. The test classes `DefaultFilesCacheTests`, `LRUFilesCacheTests`, `NullFilesCacheTests`, `SoftRefFilesCacheTests` and `WeakRefFilesCacheTests` were migrated, but nothing references them any more. Surefire excludes `**/*Tests.java`, since those classes need a suite to set up the file system, so these tests have not run since then. This PR adds the suites back in the JUnit 5 form that `LocalProviderTest` uses: - `AbstractFilesCacheTest` is an `AbstractProviderTestSuite` that configures the local file system with the `FilesCache` under test and adds one `*FilesCacheTests` class. Its configuration is the same as in the old `*FilesCacheTestCase` classes. It is tagged `provider` and `local` like `LocalProviderTest`, so the suites also run with `-Dgroups=provider`. - `DefaultFilesCacheTest`, `LRUFilesCacheTest` (with `new LRUFilesCache(5)`, as before), `NullFilesCacheTest`, `SoftRefFilesCacheTest` and `WeakRefFilesCacheTest` each run their tests. - The Javadoc of the `*FilesCacheTests` classes that still linked to the deleted `*FilesCacheTestCase` classes now links to the new ones. All 19 tests run and pass (`NullFilesCacheTest` 4, `SoftRefFilesCacheTest` 4, `WeakRefFilesCacheTest` 4, `LRUFilesCacheTest` 4, `DefaultFilesCacheTest` 3). There are no changes outside `src/test`. I noticed this while looking at [VFS-714](https://issues.apache.org/jira/browse/VFS-714) (`deleteAll()` with a `NullFilesCache`). The tests for that would naturally go into these classes, and I'd send them as a separate PR. Before you push a pull request, review this list: - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude (Anthropic) helped find the orphaned tests and draft the suite classes; I reviewed them and ran the build. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
