garydgregory commented on PR #536: URL: https://github.com/apache/commons-bcel/pull/536#issuecomment-6249713691
@AryanRG Thank you for the fix. The reported bug is real, and emitting boolean literals resolves the generated creator’s runtime failure. Closing this PR in favor of commit [7fc6cd4f](https://github.com/apache/commons-bcel/commit/7fc6cd4fa73e6b1da0da1dfb163cc2cd988c873f), which incorporates that fix and addresses additional round-trip correctness issues: - Preserves explicit `false` `ConstantValue` attributes, keeping regenerated fields usable as compile-time constants. - Allows `false` to replace an existing `true` initializer. - Matches HotSpot’s low-bit handling of noncanonical integer encodings. - Adds tests for initializer assignment, replacement, cancellation, and preservation of constant attributes. The existing `javap -p -c` comparison does not detect missing `ConstantValue` attributes. You are credited in `changes.xml`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
