SABITHSAHEB opened a new pull request, #298:
URL: https://github.com/apache/commons-jxpath/pull/298
XPath 1.0 defines `substring()`, `string-length()` and `translate()` in
terms of characters, but `CoreFunction` indexes and counts Java UTF-16 code
units. Any string value from the model that contains a supplementary character
(emoji, CJK Extension B, U+1D11E and so on) is therefore handled one surrogate
half at a time. With `$s` bound to U+1D11E followed by `abc`,
`string-length($s)` returns 5 instead of 4, `substring($s, 2)` returns a lone
`\uDD1E` followed by `abc`, `substring($s, 1, 1)` returns a lone `\uD834`, and
`translate('abc', 'b', $s)` returns `a`, `\uD834`, `c`. Those lone surrogates
are malformed UTF-16 that a UTF-8 encoder downstream turns into `?` or rejects,
and the over-count skews `string-length()` predicates used as length checks on
caller data. The fix counts and offsets by code point
(`codePointCount`/`offsetByCodePoints`, plus a code point loop in `translate`),
so strings without supplementary characters behave exactly as before.
`testStringFunctionsCountCode
Points` in `CoreFunctionTest` fails without the change and passes with it.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [x] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [x] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute? Claude (Anthropic) found the issue and drafted the fix and test. I
reviewed the change before submitting.
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
This fix was found and prepared with AI assistance and reviewed by me before
submitting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
