alhudz opened a new pull request, #1825: URL: https://github.com/apache/commons-lang/pull/1825
Repro: `new EventCountCircuitBreaker(10, 1, TimeUnit.SECONDS)`, then `incrementAndCheckState(5)` and `incrementAndCheckState(Integer.MAX_VALUE)` in the same check interval. The second call returns `true` and the breaker stays closed, although a single `incrementAndCheckState(Integer.MAX_VALUE)` on a fresh breaker opens it. The same wrap on an open breaker leaves a negative count below the closing threshold, so it closes at the next interval under heavy load. Cause: `CheckIntervalData.increment` sums the increments of an interval as `int`, and `incrementAndCheckState(Integer)` accepts any non-negative increment, so the per-interval count wraps negative. Fix: widen the private `CheckIntervalData` counter to `long`. Thresholds stay `int` and no public signature changes. This is the same fail-open case 8159dfe6 fixed for `ThresholdCircuitBreaker`. That commit added the negative-increment check to `EventCountCircuitBreaker` but left this `int` sum. `testOpeningWhenEventCountOverflows` and `testNotClosingWhenEventCountOverflows` in `EventCountCircuitBreakerTest` fail before the change and pass after. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude Code (Claude Opus 5.5). - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
