aherbert commented on PR #333: URL: https://github.com/apache/commons-math/pull/333#issuecomment-6285288248
This looks good thank you. I note that in the `DescriptiveStatistics` class the method `getPercentile` updates the `PercentileImpl` before calling the `apply` method which is synchronized in `SynchronizedDescriptiveStatistics`. So `SynchronizedDescriptiveStatistics` can change the quantile being used in the percentile computation from another thread, then wait for the computation to finish before starting another one. Please also synchronize the `gerPercentile` method. Adding a test for this would be nice to have. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
