sharanggupta opened a new pull request, #1830: URL: https://github.com/apache/commons-lang/pull/1830
The test class `ReflectionToStringBuilderOverrideExclude` doesn't end in `Test`, so it doesn't match the Surefire include pattern and its three tests have never run. The master CI log shows every other `ReflectionToStringBuilder*Test` class running and none of this one. This renames it to `ReflectionToStringBuilderOverrideExcludeTest`. With the rename, its three tests run and pass. One thing I noticed while checking it: in `toStringIncludeDoesNotExposeExcludedField`, the last assertion (`INCLUDE_2`, the email) passes only because the earlier `builder.toString()` calls already appended the email to the builder's buffer. The include list at that point is `username` and `password`. I left the test unchanged to keep this to the rename. Before you push a pull request, review this list: - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude (Anthropic) helped analyse the issue and draft the change and tests; I reviewed them against the code and ran the build. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
