hutiefang76 opened a new pull request, #415: URL: https://github.com/apache/commons-net/pull/415
`IMAPSClient(true)` starts the TLS handshake before `SocketClient._connectAction_()` applies the configured read timeout. A peer that accepts TCP but does not answer TLS can therefore leave `connect()` waiting despite a nonzero `setDefaultTimeout(...)`. Apply the existing `applySocketAttributes()` helper before the implicit handshake, matching `FTPSClient`. A zero read timeout keeps its existing unlimited-wait behavior, and explicit STARTTLS retains a timeout set after connecting. TLS protocols, certificate verification and hostname verification are unchanged. The loopback regressions cover the implicit timeout, an unlimited-wait control, explicit STARTTLS with a runtime timeout different from the default, and layered-socket timeout inheritance. Without the production line, the implicit-timeout test fails while the controls pass. Thanks to John van der Kamp for the original diagnosis and workaround in [NET-735](https://issues.apache.org/jira/browse/NET-735). Validation: - JDK 17: the final tests fail on unmodified production code (1 failure, 3 controls pass) and all 4 pass with the fix. - JDK 8: all 4 focused regressions pass. - Linux/JDK 17 default `mvn`: complete build passed, including RAT, Javadoc, Checkstyle, API compatibility and PMD; 636 tests (634 passed, 2 existing skips), no failures or errors. The macOS default build hit two unchanged FTP network-dependent tests. Both failures also reproduce with the unmodified production code. The Linux run uses the same source files and leaves those tests enabled. AI assistance: DeepSeek implemented the patch and regression tests and performed the first review; Codex coordinated the work, reviewed the diff and ran validation. This PR description is AI-generated. <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated! Before you push a pull request, review this list: - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
