alhudz opened a new pull request, #1834:
URL: https://github.com/apache/commons-lang/pull/1834
`StrSubstitutor` takes the escape character from the end of a substituted
value when another variable follows it directly in the template:
```java
Map<String, String> map = new HashMap<>();
map.put("price", "5$");
map.put("x", "X");
new StrSubstitutor(map).replace("${price}${x}"); // "5${x}", expected "5$X"
```
After `${price}` is replaced, `substituteRecursive` resumes scanning at the
end of the inserted value, and the escape check (`pos > offset && chars[pos -
1] == escape`) reaches back into that value. The value loses its trailing `$`
and `${x}` is passed through unresolved, so whoever supplies a value can stop
the next template variable from being substituted. The class Javadoc places the
escape in the template, in front of a variable reference.
The fix only accepts an escape character at or after the end of the last
substitution. Escapes written in the template, escapes inside a value,
`preserveEscapes` and nested/recursive substitution behave as before. The new
`testReplaceValueEndingWithEscape` fails without the change (`expected: <The
price is 5$lazy dog.> but was: <The price is 5${target}.>`) and passes with it.
Commons Text 1.15.0 `StringSubstitutor` behaves the same way (`"5${x}"` for
the input above), so the same change applies there.
- [ ] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [x] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute? Claude (Anthropic) found the issue and prepared the patch, test and
this description; I reviewed it before submitting.
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
