rys888 opened a new pull request, #1851: URL: https://github.com/apache/commons-lang/pull/1851
Related to [LANG-1198](https://issues.apache.org/jira/browse/LANG-1198). The issue reports that `stripEnd("85123116", "16")` was mistaken for removing the suffix "16". It actually strips trailing members of the character set and returns "85123". Clarify this distinction in stripEnd's Javadoc, link to `Strings.CS` and `Strings.removeEnd(String, CharSequence)`, and show the issue's example beside the suffix-removal result, "851231". Add a changelog entry. This is a documentation clarification addressing the reported confusion. It does not implement the issue's suggested char[] signature change or change runtime behavior. Issue closure is left to the maintainers. Validation (JDK 21, Maven 3.9.16, compiler release 8): - Full default Maven goals passed: 92,172 tests, 0 failures, 0 errors, 18 skipped; RAT, Checkstyle (0 violations), japicmp, SpotBugs, PMD, and Javadoc completed. - Command: `mvn -B -ntp -s ../commons-lang-LANG-1198-validation/maven-settings.xml`. The temporary settings point the local mirror at Maven Central; no project configuration is changed and no checks are skipped. - Compiled and ran both examples locally with Java 8 targeting; both results match the documentation. - Checked the generated HTML and both API links. - Existing StringUtilsStripTest covers repeated strip-set characters and edge cases. No additional upstream tests are needed for this documentation-only change. Checklist: - [x] Read the contribution guidelines. - [x] Read the ASF Generative Tooling Guidance. - [x] AI assistance: OpenAI Codex helped inspect the issue and existing methods, draft the documentation, and run validation. This is an AI-assisted contribution. - [x] Run a successful build using the default Maven goals. - [x] Behavioral tests: not applicable; no runtime behavior changes. Existing tests pass. - [x] Describe what changes and why. - [x] Use a meaningful commit subject and body, including an Assisted-By trailer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
